Fix/angular cli config #7485

JounQin · 2019-07-19T05:33:32Z

Issue:

What I did

outputPath, scripts, styles are required by @angular-devkit/build-angular, make sure it won't break if they are not presented.

How to test

Is this testable with Jest or Chromatic screenshots?
Yes, added.
Does this need a new example in the kitchen sink apps?
No need.
Does this need an update to the documentation?
No need.

If your answer is yes to any of these, please make sure to include it in your PR.

vercel · 2019-07-19T05:33:38Z

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-jounqin-fix-angularcliconfig.storybook.now.sh

kroeder

Thanks for the PR! LGTM
Don't know why a couple of CI tests don't pass - I'll look into this 🙂

ndelangen · 2019-08-30T18:53:32Z

Something in the test makes to unable to finish

@JounQin could you have a look what it might be?

JounQin · 2019-08-31T00:59:22Z

@ndelangen Sorry but It should not be my fault, all the merged commits have error status. I've rebased from next branch, hope it will work.

ndelangen · 2019-09-28T09:16:15Z

@kroeder I merged in next, hope the CI approves this time. Would you be able to give your final review?

kroeder · 2019-09-28T10:34:29Z

ci tests still have errors :| I also have trouble getting them green in #7747
The changes in this PR LGTM

kroeder · 2019-09-28T11:40:58Z

I changed the cli test in e187e79

I also split functions in order to improve the tests. If I get CI green we can merge it in this branch. I hope this helps

stale · 2019-10-24T12:43:12Z

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

JounQin · 2019-10-24T12:50:05Z

So the CI error has not been fixed?

And as I can see, the PR should not be prevented from merging like other merged PRs.

shilman · 2019-10-24T13:25:53Z

 FAIL  app/angular/src/server/__tests__/angular-cli_utils.test.ts
  ● Test suite failed to run

    TypeError: Cannot read property 'filter' of undefined

      1 | import fs from 'fs';
      2 | import { basename, dirname, normalize, relative, resolve, Path } from '@angular-devkit/core';
    > 3 | import {
        | ^
      4 |   getCommonConfig,
      5 |   getStylesConfig,
      6 | } from '@angular-devkit/build-angular/src/angular-cli-files/models/webpack-configs';

      at loadTsLibFiles (node_modules/@angular-devkit/build-angular/node_modules/@ngtools/webpack/src/transformers/ast_helpers.js:109:41)
      at Object.<anonymous> (node_modules/@angular-devkit/build-angular/node_modules/@ngtools/webpack/src/transformers/ast_helpers.js:46:20)
      at Object.<anonymous> (node_modules/@angular-devkit/build-angular/node_modules/@ngtools/webpack/src/transformers/index.js:14:10)
      at Object.<anonymous> (node_modules/@angular-devkit/build-angular/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:26:24)
      at Object.<anonymous> (node_modules/@angular-devkit/build-angular/node_modules/@ngtools/webpack/src/index.js:13:10)
      at Object.<anonymous> (node_modules/@angular-devkit/build-angular/src/angular-cli-files/models/webpack-configs/typescript.js:14:19)
      at Object.<anonymous> (node_modules/@angular-devkit/build-angular/src/angular-cli-files/models/webpack-configs/index.js:18:10)
      at Object.<anonymous> (app/angular/src/server/angular-cli_utils.ts:3:1)
      at Object.<anonymous> (app/angular/src/server/__tests__/angular-cli_utils.test.ts:3:1)

shilman · 2019-10-24T13:26:48Z

@JounQin @kroeder The test that's failing is the test that's introduced in this PR. We can't merge it in the current state, otherwise our builds would be broken for all PRs.

JounQin · 2019-10-24T13:38:28Z

@shilman Are you sure? The error message you mentioned seems having nothing related to this PR.

shilman · 2019-10-24T14:13:12Z

@JounQin When I click on the "Files changed" tab in this PR, it looks like that file was added in this PR. No?

ndelangen · 2019-10-24T19:22:15Z

You added the test here:
df76d44

👀

stale · 2019-11-14T20:58:13Z

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

JounQin requested review from alterx and igor-dv as code owners July 19, 2019 05:33

vercel bot had a problem deploying to staging July 19, 2019 05:33 Failure

shilman added angular bug labels Jul 19, 2019

kroeder approved these changes Jul 23, 2019

View reviewed changes

kroeder self-assigned this Jul 26, 2019

vercel bot deployed to staging July 26, 2019 23:18 View deployment

vercel bot had a problem deploying to staging August 9, 2019 15:08 Error

stale bot added the inactive label Aug 30, 2019

ndelangen approved these changes Aug 30, 2019

View reviewed changes

stale bot removed the inactive label Aug 30, 2019

ndelangen self-assigned this Aug 30, 2019

vercel bot had a problem deploying to staging August 30, 2019 17:51 Error

vercel bot had a problem deploying to staging August 31, 2019 00:44 Error

stale bot added the inactive label Sep 21, 2019

JounQin added 2 commits September 21, 2019 17:35

fix: these properties are required by @angular-devkit/build-angular now

9a4eb94

chore: add test for angular-cli_utils

df76d44

stale bot removed the inactive label Sep 21, 2019

vercel bot deployed to staging September 21, 2019 09:44 View deployment

storybookjs deleted a comment from stale bot Sep 28, 2019

Merge branch 'next' into pr/JounQin/7485

fc834de

vercel bot deployed to staging September 28, 2019 09:13 View deployment

ndelangen added this to the 5.3.0 milestone Sep 28, 2019

storybookjs deleted a comment from stale bot Sep 28, 2019

Merge branch 'next' into pr/JounQin/7485

d233835

vercel bot deployed to staging October 1, 2019 14:06 View deployment

stale bot added the inactive label Oct 24, 2019

stale bot removed the inactive label Oct 24, 2019

stale bot added the inactive label Nov 14, 2019

ndelangen closed this Nov 16, 2019

JounQin deleted the fix/angular_cli_config branch July 29, 2020 01:36

dependencies bot mentioned this pull request Jan 15, 2021

Update 14 dependencies from npm #3179

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/angular cli config #7485

Fix/angular cli config #7485

JounQin commented Jul 19, 2019

vercel bot commented Jul 19, 2019 •

edited

Loading

kroeder left a comment

ndelangen commented Aug 30, 2019 •

edited

Loading

JounQin commented Aug 31, 2019 •

edited

Loading

ndelangen commented Sep 28, 2019

kroeder commented Sep 28, 2019

kroeder commented Sep 28, 2019 •

edited

Loading

stale bot commented Oct 24, 2019

JounQin commented Oct 24, 2019

shilman commented Oct 24, 2019

shilman commented Oct 24, 2019

JounQin commented Oct 24, 2019

shilman commented Oct 24, 2019

ndelangen commented Oct 24, 2019

stale bot commented Nov 14, 2019

Fix/angular cli config #7485

Fix/angular cli config #7485

Conversation

JounQin commented Jul 19, 2019

What I did

How to test

vercel bot commented Jul 19, 2019 • edited Loading

kroeder left a comment

Choose a reason for hiding this comment

ndelangen commented Aug 30, 2019 • edited Loading

JounQin commented Aug 31, 2019 • edited Loading

ndelangen commented Sep 28, 2019

kroeder commented Sep 28, 2019

kroeder commented Sep 28, 2019 • edited Loading

stale bot commented Oct 24, 2019

JounQin commented Oct 24, 2019

shilman commented Oct 24, 2019

shilman commented Oct 24, 2019

JounQin commented Oct 24, 2019

shilman commented Oct 24, 2019

ndelangen commented Oct 24, 2019

stale bot commented Nov 14, 2019

vercel bot commented Jul 19, 2019 •

edited

Loading

ndelangen commented Aug 30, 2019 •

edited

Loading

JounQin commented Aug 31, 2019 •

edited

Loading

kroeder commented Sep 28, 2019 •

edited

Loading